[WIP] Discriminator as an experiment option #1177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable having both measurement levels 1 and 2 (kerneled data and counts) as experiment option by requesting measurement level 1 from the server and using a discriminator to convert the results to counts
Details and comments
Adding an experiment option "use_dicriminator" to ask to automatically classify the IQ data and use it in the rest of the analysis. also enable to choose the discriminator object which will be used, by using another experiment option "discriminator".
Behind the scenes, 2 circuits are added to the experiment in order to train the discriminator, and these circuits are filtered out from the rest of the analysis. There is still a problem with analysis objects which do not use CurveAnalysis, as the feature to filter out some data is part of that class.